Users' quote verification #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
commented
Mar 20, 2020
added 2 commits
March 20, 2020 16:25
|
self_register_users@6209 aka 20200323.18 vs master ewma over 30 builds from 5908 to 6191 |
achamayou
approved these changes
Mar 20, 2020
olgavrou
reviewed
Mar 23, 2020
olgavrou
approved these changes
Mar 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
- Coverage 68.28% 68.17% -0.10%
==========================================
Files 103 103
Lines 8234 8248 +14
==========================================
+ Hits 5622 5623 +1
- Misses 2612 2625 +13
|
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #926
Building on #962, this PR allows application endpoints to verify a quote supplied by an unknown (i.e. not registered in the
ccf.userstable) client against 1) the client certificate supplied by the TLS connection and 2) a list of trusted enclave measurements, stored in the newccf.users.code_idstable.Assuming that clients are running in enclaves, this lets users self-register without going through a full round of governance to add a new user, as long as new users can provide evidence that they are running in a trusted enclave.
Since the solution is very much like the join protocol, I have refactored
quoteverification.h(nowquote.has I moved quote generation code fromnodestate.hin there too).The aim is not to test this end-to-end (this would require setting up client enclaves, etc.) but provide the building blocks for app developers to do that.