-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve install with exported options #986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
reviewed
Mar 24, 2020
jumaffre
reviewed
Mar 24, 2020
jumaffre
reviewed
Mar 24, 2020
achamayou
approved these changes
Mar 24, 2020
olgavrou
approved these changes
Mar 24, 2020
jumaffre
reviewed
Mar 24, 2020
install_export_more@6426 aka 20200325.27 vs master ewma over 30 builds from 6053 to 6422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve items listed in #830.
TARGET
option toCOMPILE_TARGETS
, to distinguish it from all the other uses ofTARGET
in cmakeadd_compile_definitions
rather thanadd_definitions
, for no precise benefitSERVICE_IDENTITY_CURVE
definitions. If a user wants CCF itself to use a faster curve, they can change one line of code. But the installed headers as seen by the libccf build and the app build should match, without requiring too many obscure preprocessor defines