Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install with exported options #986

Merged
merged 25 commits into from
Mar 25, 2020

Conversation

eddyashton
Copy link
Member

Resolve items listed in #830.

  • I've renamed our TARGET option to COMPILE_TARGETS, to distinguish it from all the other uses of TARGET in cmake
  • I've used add_compile_definitions rather than add_definitions, for no precise benefit
  • I've removed SERVICE_IDENTITY_CURVE definitions. If a user wants CCF itself to use a faster curve, they can change one line of code. But the installed headers as seen by the libccf build and the app build should match, without requiring too many obscure preprocessor defines

@eddyashton eddyashton requested a review from a team as a code owner March 24, 2020 12:55
@ghost
Copy link

ghost commented Mar 25, 2020

install_export_more@6426 aka 20200325.27 vs master ewma over 30 builds from 6053 to 6422
images

@eddyashton eddyashton merged commit bd8619f into microsoft:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants