Merge pull request #1969 from microsoft/dpaul-HcExport

Address issue with export issue to xml
microsoft · Feb 7, 2024 · 68d9882 · 68d9882
2 parents d2ec3b8 + 756c271
commit 68d9882
Showing 1 changed file with 18 additions and 10 deletions.
diff --git a/Diagnostics/HealthChecker/Features/Get-HealthCheckerData.ps1 b/Diagnostics/HealthChecker/Features/Get-HealthCheckerData.ps1
@@ -123,19 +123,27 @@ function Get-HealthCheckerData {
         Write-Progress @paramWriteProgress
 
         try {
-            $analyzedResults | Export-Clixml -Path $Script:OutXmlFullPath -Encoding UTF8 -Depth 2 -ErrorAction SilentlyContinue
+            $analyzedResults | Export-Clixml -Path $Script:OutXmlFullPath -Encoding UTF8 -Depth 2 -ErrorAction Stop
+            Write-Verbose "Successfully export out the data"
         } catch {
-            Write-Verbose "Failed to Export-Clixml. Converting HealthCheckerExchangeServer to json"
-            $jsonHealthChecker = $analyzedResults.HealthCheckerExchangeServer | ConvertTo-Json
-
-            $testOutputXml = [PSCustomObject]@{
-                HealthCheckerExchangeServer = $jsonHealthChecker | ConvertFrom-Json
-                HtmlServerValues            = $analyzedResults.HtmlServerValues
-                DisplayResults              = $analyzedResults.DisplayResults
+            try {
+                Write-Verbose "Failed to Export-Clixml. Inner Exception: $_"
+                Write-Verbose "Converting HealthCheckerExchangeServer to json."
+                $jsonHealthChecker = $analyzedResults.HealthCheckerExchangeServer | ConvertTo-Json -Depth 6 -ErrorAction Stop
+
+                $testOutputXml = [PSCustomObject]@{
+                    HealthCheckerExchangeServer = $jsonHealthChecker | ConvertFrom-Json -ErrorAction Stop
+                    HtmlServerValues            = $analyzedResults.HtmlServerValues
+                    DisplayResults              = $analyzedResults.DisplayResults
+                }
+
+                $testOutputXml | Export-Clixml -Path $Script:OutXmlFullPath -Encoding UTF8 -Depth 2 -ErrorAction Stop
+                Write-Verbose "Successfully export out the data after the convert"
+            } catch {
+                Write-Red "Failed to Export-Clixml. Unable to export the data."
             }
-
-            $testOutputXml | Export-Clixml -Path $Script:OutXmlFullPath -Encoding UTF8 -Depth 2 -ErrorAction Stop
         } finally {
+            # This prevents the need to call Invoke-CatchActions
             Invoke-ErrorCatchActionLoopFromIndex $currentErrors
 
             # for now don't want to display that we output the information if ReturnDataCollectionOnly is false