Proposal: Enforce lowercase keywords #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am purposely letting the build fail until we discuss this. If we decide to move forward, this rule will update 249 scripts in the repo. |
|
Issue has been open for a while, might need to do a PR ourselves to get that addressed in the |
dpaulson45
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We have no consistent formatting of keywords. In some scripts, keywords change cases every few lines.
PoshCode says keywords should be lowercase.
PSScriptAnalyzer is most likely headed for a keywords-must-be-lowercase rule. There are multiple issues open, but no one has done the work yet. You can start following the trail of issues at PowerShell/PSScriptAnalyzer#767.
Fix:
Until PSScriptAnalyzer adds this check, add our own check.