Allow trailing back-slashes in paths and use proper join-path/io class to handle paths #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lash. For $OutputFilePath, you do the same as well as test the path. The description mentions the trailing "requirement" of one, but not the other - inconsistent. Test-Path for both suffices; accepting trailing slashes is convenient, as tab-completion adds trailing back-slash automatically. Used Join-Path etc to properly construct paths, and [System.IO.Path]::changeExtension instead of string operations.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thank you for the PR. Please make CodeFormatter happy:
Looks good to me otherwise. You can run CodeFormatter locally prior to submission as noted in CONTRIBUTING.md. |
|
@michelderooij please address the code formatting rule as soon as you can. |
Corrected casing
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dpaulson45
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
For $XMLDirectoryPath, you check if the path does not end in a back-slash. For $OutputFilePath, you do the same as well as test the path. The description mentions the trailing "requirement" of one, but not the other - inconsistent. Test-Path for both suffices.
Reason:
Accepting trailing slashes is convenient, as tab-completion adds trailing back-slash automatically. Also removes inconsistency.
Fix:
Use Test-Path for both in parameter validation. Used Join-Path etc to properly construct paths, and [System.IO.Path]::changeExtension instead of string operations.
Validation:
Tested against local and remote servers, using local and UNC paths