-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Logging Default Updates #2273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required in order to get Invoke-Command to work
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is completing most of #2245 |
lusassl-msft
previously approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, no changes required, just a small suggestion for improving the unit test.
bill-long
reviewed
Jan 28, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
lusassl-msft
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When running
Invoke-Command
against another computer where you don't have a script block that you want to include a lot of overhead to log on the server that we are running on (a remote server), then you lose the ability to log out information that can be useful for logging/debugging.Fix:
Improved the ability of Exchange Log Collector to be a tester of Remote Logging for some sample functions that we already have in place.
Improved the operation of injecting functions into a main script block to allow for remote execution so you don't need to duplicate code everywhere when you want to have the logging functionality working around a script block that you want to execute remotely.
Validation:
Lab tested