Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Logging Default Updates #2273

Merged
merged 14 commits into from
Jan 28, 2025
Merged

Remote Logging Default Updates #2273

merged 14 commits into from
Jan 28, 2025

Conversation

dpaulson45
Copy link
Member

Issue:
When running Invoke-Command against another computer where you don't have a script block that you want to include a lot of overhead to log on the server that we are running on (a remote server), then you lose the ability to log out information that can be useful for logging/debugging.

Fix:
Improved the ability of Exchange Log Collector to be a tester of Remote Logging for some sample functions that we already have in place.

Improved the operation of injecting functions into a main script block to allow for remote execution so you don't need to duplicate code everywhere when you want to have the logging functionality working around a script block that you want to execute remotely.

Validation:
Lab tested

@dpaulson45 dpaulson45 added the Enhancement New feature or request label Jan 24, 2025
@dpaulson45 dpaulson45 requested a review from a team as a code owner January 24, 2025 15:08
@dpaulson45
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dpaulson45
Copy link
Member Author

This is completing most of #2245

lusassl-msft
lusassl-msft previously approved these changes Jan 28, 2025
Copy link
Contributor

@lusassl-msft lusassl-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no changes required, just a small suggestion for improving the unit test.

@dpaulson45
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lusassl-msft lusassl-msft self-requested a review January 28, 2025 16:26
@dpaulson45 dpaulson45 merged commit 2469db3 into main Jan 28, 2025
4 checks passed
@dpaulson45 dpaulson45 deleted the dpaul-RemoteLoggingChanges branch January 28, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants