Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add Cmake for Chakra Examples #50

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kphillisjr
Copy link

This implements the cmake builder for the Chakra Core samples. This also gets the Chakra OpenGL Engine example running on Ubuntu 16.04LTS. To build this example just run build.sh.

Also as a note, This needs testing/fixes for windows.

This example will automatically link to ChakraCore should the source
be placed in the folder ChakraCore in the main source tree.
This is a copy of the build script for ChakraCore. The only difference
is that the debian package creation is removed.
This should help keep the source tree clean. This will ignore most of
the automatically generated files.
This should allow users to run the Hello World application from the
build directory.
This occurs when a symbolic link is used to create the ChakraCore Folder.
This target should be used by all of the examples.
With the previous changes this should work all the time.
This is the cmake files used to compile the OpenGL Example.
This allows the OpenGL Engine example to compile on linux. The only issue is that
this example currently does not run as intended on linux.
The new API calls fixes the runtime linking to shared libraries.

V2: Fix whitespace issues.
@liminzhu
Copy link
Member

Thank you @kphillisjr . @obastemur can you take a look?

@kphillisjr
Copy link
Author

@liminzhu, This is on Hold until I redo the main ChakraCore pull. ( see: chakra-core/ChakraCore#2084 )

@kphillisjr
Copy link
Author

@liminzhu, This pull request is a bit outdated. I made a couple of changes in another branch where I condensed most of the commits in this into two or three total. You can test the new changes in the steps mentioned on this ChakraCore pull request ( chakra-core/ChakraCore#2111 )

@kphillisjr
Copy link
Author

@liminzhu, There was some major changes to how I did things in a way that would greatly simplify the linking of ChakraCore. The new pull request ( Microsoft/ChakraCore#2138 ) introduces a new library on XPlat called ChakraCoreStatic. This reduces the number of libraries that users haft to link to get ChakraCore working, and also addresses the runtime issues chakracore displays on OSX/Linux in regards to library initialization. I will need to rebase this pull request on the changes made by this, and hopefully I could get some of the other developers to sign off on one of the fixes for automatic configuration of ChakraCore using cmake functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants