Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezing issue due to V8 #33

Closed
andrea-s opened this issue Dec 19, 2017 · 2 comments
Closed

Freezing issue due to V8 #33

andrea-s opened this issue Dec 19, 2017 · 2 comments

Comments

@andrea-s
Copy link

Hey,

just wanted to let you know that there is a deadlock issue that affects V8 (and ClearScript) - as detailed here: https://bugs.chromium.org/p/v8/issues/detail?id=6933

I've been noticing that sometimes CPU would get stuck to 100% (per core) since the upgrade to 5.5. After some investigation I've concluded that this is the likely culprit. Now I've been running the patched version of V8 since a couple of days and it looks like the issue is resolved.

This is what I did:

  • cherry-picked commit ac0fe8ec from V8 upstream (v8/v8@ac0fe8e)
  • recompiled V8

Basically the same thing node did here: nodejs/node#17695

I'm attaching the corresponding patch here - has anyone noticed the same behavior with ClearScript 5.5?

0001-interpreter-Remove-TryInstallOptimizedCode.patch,txt

@ClearScriptLib
Copy link
Collaborator

@andrea-s Thank you very much for that information!

We're close to releasing Version 5.5.1 paired with V8 6.3. It looks like the V8 fix you linked will not be merged into the 6.3 stable branch, so we'll modify V8Update to apply it explicitly.

Thanks again!

ClearScriptLib added a commit that referenced this issue Jan 1, 2018
…pector; added V8ScriptEngineFlags.AwaitDebuggerAndPauseOnStart (GitHub Issue #22); added ToString() overrides to exception classes (GitHub Issue #16); updated debugging and API documentation. Tested with V8 6.3.292.48 + infinite loop fix (GitHub Issue #33).
@ClearScriptLib
Copy link
Collaborator

Version 5.5.1 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants