Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep original line ending in merge postactions #306

Open
prupipho opened this issue Apr 7, 2021 · 0 comments
Open

Keep original line ending in merge postactions #306

prupipho opened this issue Apr 7, 2021 · 0 comments
Labels
enhancement New feature or request WebTS Tag to identify issues related to Web Template Studio
Milestone

Comments

@prupipho
Copy link
Contributor

prupipho commented Apr 7, 2021

Line ending change during merging post-action with the original file.

Due to this issue in WebTS while working for React Native we realised that in some scenarios we are changing the line ending of the file during the merge.
We should try doing the same thing we do with original Encoding:

  • get original file ending
  • check the new file has the same ending
  • keep that line ending on the new generated file after a post-action

WIP - work in progress:

@prupipho prupipho added the enhancement New feature or request label Apr 7, 2021
@prupipho prupipho added this to the Backlog milestone Apr 7, 2021
@prupipho prupipho self-assigned this Apr 7, 2021
@sibille sibille changed the title Keep original line ending Keep original line ending in merge postactions Apr 14, 2021
@sibille sibille modified the milestones: Backlog, WebTS 0.6 May 4, 2021
@sibille sibille modified the milestones: WebTS 0.6, WebTS 0.7 May 11, 2021
@sibille sibille modified the milestones: WebTS 0.7, Backlog May 24, 2021
@sibille sibille added the WebTS Tag to identify issues related to Web Template Studio label May 24, 2021
@prupipho prupipho removed their assignment Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WebTS Tag to identify issues related to Web Template Studio
Projects
None yet
Development

No branches or pull requests

2 participants