New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep original line ending in merge postactions #309

Closed

prupipho wants to merge 4 commits into microsoft:dev from prupipho:prupipho-306-eol_change

Contributor

prupipho commented Apr 29, 2021 •

edited

Loading

PR checklist

Quick summary of changes
First approach to keep original line ending in merge postactions and when adding JsonDictionaryItem
Decide risks before deciding to complete
Which issue does this PR relate to? Keep original line ending in merge postactions #306

Notes:

need to fix merge post action AddJsonDictionaryItem

prupipho added 4 commits

April 28, 2021 18:41


          * first approach to keep line ending

21eae51


          * accidentally missing file

6d4af56

* remove Mac ending


          * remove enums and just use a constant

8ec4545


          Merge branch 'dev' into prupipho-306-eol_change

5bfe399

prupipho closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mikebattista Awaiting requested review from mikebattista mikebattista will be requested when the pull request is marked ready for review mikebattista is a code owner

sibille Awaiting requested review from sibille sibille will be requested when the pull request is marked ready for review sibille is a code owner

mvegaca Awaiting requested review from mvegaca mvegaca will be requested when the pull request is marked ready for review mvegaca is a code owner

dgomezc Awaiting requested review from dgomezc dgomezc will be requested when the pull request is marked ready for review dgomezc is a code owner

Labels

None yet