Skip to content

Commit

Permalink
Add missing 'readonly' modifiers (#1664)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Sergio0694
Sergio0694 authored Jul 9, 2024
1 parent 8576896 commit d600811
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 27 deletions.
36 changes: 18 additions & 18 deletions src/Authoring/WinRT.SourceGenerator/GenericVtableInitializerStrings.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private static string GetIEnumerableInstantiation(string genericType, string abi
string iEnumerableInstantiation = $$"""
internal static class IEnumerable_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -228,7 +228,7 @@ private static string GetIEnumeratorInstantiation(string genericType, string abi
string iEnumeratorInstantiation = $$"""
internal static class IEnumerator_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -332,7 +332,7 @@ private static string GetIListInstantiation(string genericType, string abiType,
string iListInstantiation = $$"""
internal static class IList_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -569,7 +569,7 @@ private static string GetIReadOnlyListInstantiation(string genericType, string a
string iReadOnlylistInstantiation = $$"""
internal static class IReadOnlyList_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -674,7 +674,7 @@ private static string GetIDictionaryInstantiation(string genericKeyType, string
string iDictionaryInstantiation = $$"""
internal static class IDictionary_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericKeyType)}}_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericValueType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -829,7 +829,7 @@ private static string GetIReadOnlyDictionaryInstantiation(string genericKeyType,
string iReadOnlyDictionaryInstantiation = $$"""
internal static class IReadOnlyDictionary_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericKeyType)}}_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericValueType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -933,7 +933,7 @@ private static string GetKeyValuePairInstantiation(string genericKeyType, string
string keyValuePairInstantiation = $$"""
internal static class KeyValuePair_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericKeyType)}}_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericValueType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -990,7 +990,7 @@ private static string GetEventHandlerInstantiation(string genericType, string ab
string eventHandlerInstantiation = $$"""
internal static class EventHandler_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1048,7 +1048,7 @@ private static string GetTypedEventHandlerInstantiation(EquatableArray<GenericPa
string typedEventHandlerInstantiation = $$"""
internal static class TypedEventHandler_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1106,7 +1106,7 @@ private static string GetCompletedHandlerInstantiation(string completedHandler,
string completedHandlerInstantiation = $$"""
internal static class {{completedHandler.Split('.')[^1]}}_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1141,7 +1141,7 @@ private static string GetChangedHandlerInstantiation(string changedHandler, stri
string changedHandlerInstantiation = $$"""
internal static class {{changedHandler.Split('.')[^1]}}_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1179,7 +1179,7 @@ private static string GetProgressHandlerInstantiation(string progressHandler, st
string progressHandlerInstantiation = $$"""
internal static class {{progressHandler.Split('.')[^1]}}_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1238,7 +1238,7 @@ private static string GetIAsyncActionWithProgressInstantiation(EquatableArray<Ge
string instantiation = $$"""
internal static class IAsyncActionWithProgress_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1353,7 +1353,7 @@ private static string GetIAsyncOperationWithProgressInstantiation(EquatableArray
string instantiation = $$"""
internal static class IAsyncOperationWithProgress_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1473,7 +1473,7 @@ private static string GetIAsyncOperationInstantiation(EquatableArray<GenericPara
string instantiation = $$"""
internal static class IAsyncOperation_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1553,7 +1553,7 @@ private static string GetIMapChangedEventArgsInstantiation(EquatableArray<Generi
string instantiation = $$"""
internal static class IMapChangedEventArgs_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1612,7 +1612,7 @@ private static string GetIObservableMapInstantiation(EquatableArray<GenericParam
string instantiation = $$"""
internal static class IObservableMap_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down Expand Up @@ -1666,7 +1666,7 @@ private static string GetIObservableVectorInstantiation(EquatableArray<GenericPa
string instantiation = $$"""
internal static class IObservableVector_{{GetGenericParametersAsString(genericParameters, "_", false)}}
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;
private static unsafe bool Init()
Expand Down
18 changes: 9 additions & 9 deletions src/cswinrt/strings/additions/Windows.Storage.Streams/StreamTaskAdaptersImplementation.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Windows.Storage.Streams
// one for the scenarios which are used by StreamOperationsImplementations for its task adapters.
internal static class StreamTaskAdaptersImplementation
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -97,7 +97,7 @@ private static string LookupRuntimeClassName(Type type)

private static class IAsyncOperationWithProgress_uint_uint
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -213,7 +213,7 @@ private static unsafe int Do_Abi_get_Completed_3(IntPtr thisPtr, IntPtr* __retur

private static class AsyncOperationProgressHandler_uint_uint
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -268,7 +268,7 @@ private static unsafe void Invoke(IObjectReference objRef, global::Windows.Found

private static class AsyncOperationWithProgressCompletedHandler_uint_uint
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -298,7 +298,7 @@ private static unsafe int Do_Abi_Invoke(IntPtr thisPtr, IntPtr asyncInfo, global

private static class IAsyncOperationWithProgress_IBuffer_uint
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -415,7 +415,7 @@ private static unsafe int Do_Abi_get_Completed_3(IntPtr thisPtr, IntPtr* __retur

private static class AsyncOperationProgressHandler_IBuffer_uint
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -473,7 +473,7 @@ private static unsafe void Invoke(

private static class AsyncOperationWithProgressCompletedHandler_IBuffer_uint
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -503,7 +503,7 @@ private static unsafe int Do_Abi_Invoke(IntPtr thisPtr, IntPtr asyncInfo, global

private static class IAsyncOperation_bool
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down Expand Up @@ -575,7 +575,7 @@ private static unsafe int Do_Abi_get_Completed_1(IntPtr thisPtr, IntPtr* __retur

private static class AsyncOperationCompletedHandler_bool
{
private static bool _initialized = Init();
private static readonly bool _initialized = Init();
internal static bool Initialized => _initialized;

private static unsafe bool Init()
Expand Down

0 comments on commit d600811

Please sign in to comment.