Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class marshalling sometimes directly uses ThisPtr instead of correctly marshalling #143

Closed
jkoritzinsky opened this issue Apr 15, 2020 · 1 comment
Closed

Class marshalling sometimes directly uses ThisPtr instead of correctly marshalling #143

jkoritzinsky opened this issue Apr 15, 2020 · 1 comment

Comments

@jkoritzinsky
Copy link
Member

When we're marshalling a runtime class, we sometimes just directly access the ThisPtr property instead of actually marshalling the class instance to native. We should actually use the marshalling infrastructure to explicitly handle user subclasses of WinRT classes.
@jkoritzinsky
Copy link
Member Author

This marshalling is also calling ClassType.FromAbi directly, which breaks RCW caching.

jkoritzinsky added a commit that referenced this issue Apr 16, 2020
@jkoritzinsky
Fix RCW caching. Fixes #143
debb39c
@jkoritzinsky jkoritzinsky mentioned this issue Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkoritzinsky