-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSWinrt does not support ready to run #442
Comments
@ujjwalchadha this may not be a CsWinRT issue - William is following up with more investigation |
This looks like a bug in the .NET SDK with runtime packs with The <ItemGroup>
<_ResolvedCopyLocalPublishAssets Include="@(RuntimePackAsset)" Condition="'$(SelfContained)' == 'true'" />
</ItemGroup> The <!-- Include RuntimePackAsset where RuntimePackAlwaysCopyLocal is true -->
<_ResolvedCopyLocalPublishAssets Include="@(RuntimePackAsset)"
Condition="'%(RuntimePackAsset.RuntimePackAlwaysCopyLocal)' == 'true'">
<DestinationSubPath>%(ReferenceCopyLocalPaths.DestinationSubDirectory)%(ReferenceCopyLocalPaths.Filename)%(ReferenceCopyLocalPaths.Extension)</DestinationSubPath>
</_ResolvedCopyLocalPublishAssets> So for self-contained apps, the items from the Microsoft.Windows.SDK.NET.Ref pack get added twice. We should update the logic to avoid this. |
This probably isn't related, but I just came across this issue when publishing with @dplaisted and @wli3, is this a known issue, or just related to windows? "c:\dev\winui\Samples\WinUICsDesktopSampleApp\WinUICsDesktopSampleApp.sln" (default target) (1:2) ->
Time Elapsed 00:00:37.11 c:\dev\winui>.buildtools\MSBuild\Current\Bin\MSBuild.exe Samples\XamlControlsGallery\XamlControlsGallery.Desktop.sln /p:Platform=x86 /p:Configuration=Debug /restore /m /bl c:\dev\winui.buildtools\MSBuild\Current\Bin.buildtools\MSBuild\Current\Bin\MSBuild.exe /bl /m /p:Platform=x86 /p:Configuration=Debug /restore Samples\XamlControlsGallery\XamlControlsGallery.Desktop.sln |
@stevenbrix Please open a separate issue for that and include repro steps. |
This has been fixed by the latest .net. (net 5.0.100 RTM or greater). |
ConsoleApp21.zip
use above asset. In commandline run
dotnet publish -r win-x64
. Get error:C:\Program Files\dotnet\sdk\5.0.100-rc.2.20468.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(401,28): error MSB4094: "C:\Users\wul.nuget\packages\microsoft.windows.sdk.net.ref\10.0.19041.1-preview\lib\Microsoft.Windows.SDK.NET.dll;C:\Users\wul.nuget\packages\microsoft.windows.sdk.net.ref\10.0.19041.1-preview\lib\Microsoft.Windows.SDK.NET.dll" is an invalid value for the "CompilationEntry" parameter of the "RunReadyToRunCompiler" task. Multiple items cannot be passed into a parameter of type "Microsoft.Build.Framework.ITaskItem". [C:\work\temp\ConsoleApp21\ConsoleApp21\ConsoleApp21.csproj]
The text was updated successfully, but these errors were encountered: