Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block setter-only properties (winrt diagnostics) #650

Closed
j0shuams opened this issue Jan 5, 2021 · 0 comments · Fixed by #651
Closed

Block setter-only properties (winrt diagnostics) #650

j0shuams opened this issue Jan 5, 2021 · 0 comments · Fixed by #651
Assignees
@j0shuams
Labels
enhancement New feature or request fixed Issue has been fixed in an upcoming or existing release
Milestone
Release 1.1.1

Comments

@j0shuams
Copy link
Contributor

j0shuams commented Jan 5, 2021 •
edited
Loading

In the windows runtime diagnostics for authoring components:

public int NumberProperty { private get; set; } should not be allowed -- there are no diagnostic checks for it at the moment

public int NumberProperty { get; private set; } should be allowed
@j0shuams j0shuams added the enhancement New feature or request label Jan 5, 2021
@j0shuams j0shuams self-assigned this Jan 5, 2021
@j0shuams j0shuams linked a pull request Jan 5, 2021 that will close this issue
Authoring: Diagnostic for private getter #651
Merged
@AdamBraden AdamBraden added this to the Release 1.2.0 milestone Jan 6, 2021
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j0shuams j0shuams

Labels
enhancement New feature or request fixed Issue has been fixed in an upcoming or existing release
Projects
None yet
Milestone
Release 1.1.1
Development

Successfully merging a pull request may close this issue.

Authoring: Diagnostic for private getter microsoft/CsWinRT
3 participants
@AdamBraden @angelazhangmsft @j0shuams