Authoring: Diagnostic for private getter #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0shuams
force-pushed
the
jlarkin/privategetterdiagnostic
branch
from
80828e9
to
f67cb4a
Compare
manodasanW
reviewed
Jan 5, 2021
manodasanW
reviewed
Jan 5, 2021
Scottj1s
approved these changes
Jan 6, 2021
manodasanW
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a diagnostic missed for private getters, I am adding a positive and negative test case for private setter and private getter on properties (respectively). My change is to look at the method accessibility on all property symbols, via the
CheckPropertiesfunction -- which is the new name ofCheckPropertySignature.The function
CheckPropertySignatureused in checking classe and interfaces, and this check really only needs to happen for classes. Originally, I thought to take the loop out of the helper function and leave it in the class loop ofFindDiagnostics. But felt like looping over properties twice wasn't essential. Open to feedback on whether to do this check for interfaces or not.