Authoring: Diagnostic for private getter

src/Authoring/DiagnosticTests/NegativeData.cs

@@ -2,6 +2,16 @@ namespace DiagnosticTests
 {
  public sealed partial class UnitTesting
  {
+ private const string PrivateGetter = @"
+namespace DiagnosticTests
+{
+ public sealed class PrivateGetter
+ {
+ public int MyInt { private get; set; }
+ }
+}";
+
+
  private const string SameNameNamespacesDisjoint = @"
 namespace DiagnosticTests
 {

src/Authoring/DiagnosticTests/PositiveData.cs

@@ -1,7 +1,17 @@
 namespace DiagnosticTests
 {
  public sealed partial class UnitTesting
+ {
+
+ private const string Valid_PrivateSetter = @"
+namespace DiagnosticTests
+{
+ public sealed class PrivateSetter
  {
+ public int MyInt { get; private set; }
+ }
+}";
+
  private const string Valid_RollYourOwnAsyncAction = @"
 using System;
 using Windows.Foundation;

src/Authoring/DiagnosticTests/UnitTesting.cs

@@ -96,6 +96,8 @@ private static IEnumerable<TestCaseData> InvalidCases
  {
  get 
  {
+ // private getter
+ yield return new TestCaseData(PrivateGetter, WinRTRules.PrivateGetterRule).SetName("Property. PrivateGetter");
  // namespace tests
  yield return new TestCaseData(SameNameNamespacesDisjoint, WinRTRules.DisjointNamespaceRule).SetName("Namespace. isn't accessible without Test prefix, doesn't use type");
  yield return new TestCaseData(NamespacesDifferByCase, WinRTRules.NamespacesDifferByCase).SetName("Namespace. names only differ by case");
@@ -392,6 +394,7 @@ private static IEnumerable<TestCaseData> ValidCases
  {
  get
  {
+ yield return new TestCaseData(Valid_PrivateSetter).SetName("Valid. Property. Private Setter");
  yield return new TestCaseData(Valid_RollYourOwnAsyncAction).SetName("Valid. AsyncInterfaces. Implementing your own IAsyncAction");
  yield return new TestCaseData(Valid_CustomDictionary).SetName("Valid. CustomProjection. IDictionary<string,BasicStruct>");
  yield return new TestCaseData(Valid_CustomList).SetName("Valid. CustomProjection. IList<DisposableClass>");

src/Authoring/WinRT.SourceGenerator/DiagnosticUtils.cs

@@ -64,9 +64,10 @@ public void FindDiagnostics()
 
  // check for things in nonWindowsRuntimeInterfaces
  ImplementsInvalidInterface(classSymbol, @class);
-
- CheckPropertySignature(props, classId);
-
+
+ CheckProperties(props, classId);
+
+ // check types -- todo: check for !valid types
  CheckMethods(publicMethods, classId);
  }
 
@@ -87,7 +88,7 @@ public void FindDiagnostics()
 
  ImplementsInvalidInterface(interfaceSym, @interface);
 
- CheckPropertySignature(props, @interface.Identifier);
+ CheckProperties(props, @interface.Identifier);
 
  CheckMethods(methods, @interface.Identifier);
  }
@@ -222,13 +223,18 @@ private void CheckMethods(IEnumerable<MethodDeclarationSyntax> methodDeclaration
  /// <summary>Looks at all the properties of the given class and checks them for improper array types (System.Array instances, multidimensional, jagged)</summary>
  ///<param name="props">collection of properties</param><param name="typeId">containing class/interface</param>
  /// <returns>True iff any of the invalid array types are used in any of the propertyy signatures in the given class</returns>
- private void CheckPropertySignature(IEnumerable<PropertyDeclarationSyntax> props, SyntaxToken typeId)
+ private void CheckProperties(IEnumerable<PropertyDeclarationSyntax> props, SyntaxToken typeId)
  {
  foreach (var prop in props)
  {
  var propSym = GetModel(prop.SyntaxTree).GetDeclaredSymbol(prop);
  var loc = prop.GetLocation();
 
+ if (!propSym.GetMethod.DeclaredAccessibility.Equals(Accessibility.Public))
+ {
+ Report(WinRTRules.PrivateGetterRule, loc, prop.Identifier);
+ }
+
  ReportIfInvalidType(propSym.Type, loc, prop.Identifier, typeId);
  foreach (var arg in propSym.Parameters)
  {

src/Authoring/WinRT.SourceGenerator/WinRTRules.cs

@@ -21,6 +21,11 @@ private static DiagnosticDescriptor MakeRule(string id, string title, string mes
  helpLinkUri: "https://docs.microsoft.com/en-us/previous-versions/hh977010(v=vs.110)");
  }
 
+ public static DiagnosticDescriptor PrivateGetterRule = MakeRule(
+ "WME", 
+ "Property must have public getter",
+ "Property '{0}' does not have a public getter method. Windows Metadata does not support setter-only properties.");
+
  public static DiagnosticDescriptor DisjointNamespaceRule = MakeRule(
  "WME1044",
  "Namespace is disjoint from main (winmd) namespace",