add winui desktop test app #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottj1s
reviewed
Apr 8, 2020
Scottj1s
reviewed
Apr 8, 2020
Scottj1s
reviewed
Apr 8, 2020
Scottj1s
reviewed
Apr 8, 2020
Scottj1s
reviewed
Apr 8, 2020
Scottj1s
reviewed
Apr 8, 2020
Scottj1s
reviewed
Apr 9, 2020
Scottj1s
reviewed
Apr 9, 2020
Scottj1s
reviewed
Apr 9, 2020
|
just one more request - gather all winui projects into a subdir |
Will do - I wish VS did this automatically when you created solution folders. |
Scottj1s
reviewed
Apr 10, 2020
| @@ -1,5 +1,10 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <!-- Beware Dragons: | |||
There was a problem hiding this comment.
could you drop these specific comments so we know when to revisit?
- VS 16.5 regression - can't find _CheckForGenerateAppxPackageOnBuild target
- .NET 5 SDK is in the midst of netcoreapp5.0 -> net5.0 TFM transition, failing builds
Scottj1s
approved these changes
Apr 10, 2020
added 9 commits
April 10, 2020 13:27
stevenbrix
force-pushed
the
stevenbrix/winui-app
branch
from
833ffea
to
d6ab3bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a WinUI test app to the cswinrt.sln. In order to properly build the test app, we have a separate project which builds the projection. This is primarily due to the way that the WinUI markup compiler works - during our Pass1 compilation we need a reference assembly with the platform types - and when building the projection into the app, we don't have that assembly yet.
This also has a checked-in version of our workaround for the
ContentPropertyAttributenot being generated.This app reproes the issues that we are currently hitting with WinUI.