New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build issues due to adding WinUI projection #132

Merged

Scottj1s merged 3 commits into master from stevenbrix/fixbuild

Apr 13, 2020

Contributor

stevenbrix commented Apr 13, 2020

There were a few issues with the build that somehow didn't get caught while working on this:

Even though I set ExcludeAssets=Build, Nuget was still importing the WinUI targets, which depend on TargetPlatformVersion to be specified
After setting TargetPlatformVersionin the Projection project, there was a timing issue preventing the generated files from being compiled. This is why a subsequent build worked - because the files were already in the Generated Files directory

Steven Kirbach added 3 commits

April 11, 2020 19:44


add targetplatformversion to build

82c188a


more fixes

060ce41


fix timing of projection generation

f89e0e8

Scottj1s merged commit c37a2aa into master

Scottj1s deleted the stevenbrix/fixbuild branch

April 13, 2020 17:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment