Simplify factory generated code. #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaanstra
force-pushed
the
user/jlaans/simplify-factory
branch
from
9fdc803
to
5b7d29d
Compare
manodasanW
approved these changes
Sep 12, 2023
manodasanW
added a commit
that referenced
this pull request
Sep 26, 2023
* Fix issues from dictionary caching (#1353) * Add tests to exercise different ABI types for generic of dictionary * Revert lookup cache to fix rests where ABI Signature can be different. * Bring over API compat validation updates * Undo comment * Undo one more comment * Simplify factory generated code. (#1355) * Include CsWInRT.exe in the inputs so MSBuild reruns the target if CsWinRT.exe got updated. (#1356) * Manually generate signatures for some PInvokes to handle SetLastError. (#1354) * Manually generate signatures to handle SetLastError. * Use new signatures on .NET 6 and newer. * Use sbyte* --------- Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com> --------- Co-authored-by: Johan Laanstra <jlaans@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing seems to need this code for IDIC.