Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with properties implemented across multiple static interfaces #1415

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

manodasanW
Copy link
Member

Today if you had a static class which had a property implemented across multiple interfaces (i.e. get in one, set in the other), you would get "Could not find property getter interface". This is because we didn't merge properties across interfaces for static classes like we did for regular classes. This brings that logic that we had in classes to do merging of properties to static classes.

Fix #1414

Copy link
Contributor

@vineeththomasalex vineeththomasalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manodasanW manodasanW merged commit 35d5018 into staging/AOT Dec 14, 2023
9 checks passed
@manodasanW manodasanW deleted the manodasanw/staticproperty branch December 14, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants