Fix diagnostics for namespaces with internal partial types #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s due to the IsPublic check treated partial as public
Co-authored-by: Vineeth Thomas Alex <vineeththomasalex@gmail.com>
vineeththomasalex
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostics analyzer for namespaces found all the namespaces which had public types and then made sure they are a subset of the one which the authored component is. As part of determining public types, the check also considered partial types to be public with the assumption that it would later to be checked to figure out whether it is really public or not. But for the namespace diagnostics this wasn't done as it is done in other scenarios. In addition, partial types don't matter for namespace diagnostics as the diagnostics analyzer will see at least one of the partial types with its declared accessibility. Due to that, this PR addresses this issue by making the namespace check only look for public types and not partial ones.
Fixes #1425