Optimize ContextCallback on modern .NET #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/optimize-context-callback
branch
3 times, most recently
from
6b2519c
to
7962345
Compare
Sergio0694
force-pushed
the
user/sergiopedri/optimize-context-callback
branch
from
5c81749
to
3896502
Compare
jlaanstra
approved these changes
Jan 25, 2024
manodasanW
approved these changes
Jan 25, 2024
|
Saves ~30 KB. Less when considering the other two PRs, but still a few KBs either way:
|
manodasanW
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Optimize ContextCallback on modern .NET * I love GC holes (also was using the wrong IID) * Remove duplicate IID definitions * Minor code tweaks, add more comments * Copy callback parameter into a local * Restore .NET Standard context callback logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the context callback logic on modern .NET with the following changes:
ObjectReference<T>entirely, doing manual interop insteadI'm expecting a minor performance increase, and minor binary size improvements