Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IActivationFactoryMethods.ActivateInstance into WinRT.Runtime #1489

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Move IActivationFactoryMethods.ActivateInstance into WinRT.Runtime #1489

merged 2 commits into from
Feb 2, 2024

Conversation

Sergio0694
Copy link
Member

This PR moves IActivationFactoryMethods.ActivateInstance into WinRT.Runtime to avoid duplication. Also:

  • Fixes a potential memory corruption issue (instance wasn't being kept alive)
  • Adds documentation
  • Removes unnecessary generic type parameter

@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/move-IActivationFactoryMethods branch from 7d85657 to 2671191 Compare February 2, 2024 10:22
@Sergio0694 Sergio0694 merged commit 900a0e5 into staging/AOT Feb 2, 2024
9 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/move-IActivationFactoryMethods branch February 2, 2024 14:08
@Sergio0694 Sergio0694 mentioned this pull request Feb 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaanstra jlaanstra jlaanstra approved these changes

@manodasanW manodasanW manodasanW approved these changes

Assignees
No one assigned
Labels
trimming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sergio0694 @jlaanstra @manodasanW