Remove/move internal vftbl types #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Feb 2, 2024
| { | ||
| // This is internal both in the embedded case, but also if we're on modern .NET, | ||
| // because projections only use this vftbl type downlevel, and running older | ||
| // projections against a .NET version of CsWinRT is not supported. |
There was a problem hiding this comment.
Suggested change
| // projections against a .NET version of CsWinRT is not supported. | |
| // projections against a newer version of CsWinRT is not supported. |
manodasanW
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks two vftbl types we had in the shared code:
IActivationFactoryVftbl, as it was not needed (should also save minimal size)IReferenceTrackerTargetVftblto WinRT.Runtime, as it's only needed internally nowIDelegateVftblto WinRT.Runtime, only make it public downlevel (otherwise, internal)