Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress incorrect CA2257 warnings #1509

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Sergio0694
Copy link
Member

This PR suppresses some incorrect CS2257 warnings that were polluting our build output. As per the docs:

"Since a type that implements IDynamicInterfaceCastable may not implement a dynamic interface in metadata, calls to an instance interface member that is not an explicit implementation defined on this type are likely to fail at run time. To avoid run-time errors, mark new interface members static."

This clearly doesn't apply to these cases, since these members were just nested types, and not something you can invoke.

@Sergio0694 Sergio0694 self-assigned this Feb 21, 2024
@Sergio0694 Sergio0694 removed their assignment Feb 21, 2024
@manodasanW
Copy link
Member

Related to dotnet/roslyn-analyzers#7106

@Sergio0694 Sergio0694 merged commit 380d66a into staging/AOT Feb 21, 2024
9 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/suppress-wrong-ca2257 branch February 21, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants