Address issues discovered after fixing AOT warnings #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
reviewed
Feb 22, 2024
Sergio0694
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Fix build breaks from AOT warning fixes * Improvements to GUID helper type lookup to avoid needing instantiated generic type * Move around where helper type is initialized to handle more scenarios * Remove commented code
manodasanW
added a commit
that referenced
this pull request
Feb 29, 2024
* Fix build breaks from AOT warning fixes * Improvements to GUID helper type lookup to avoid needing instantiated generic type * Move around where helper type is initialized to handle more scenarios * Remove commented code
Sergio0694
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Fix build breaks from AOT warning fixes * Improvements to GUID helper type lookup to avoid needing instantiated generic type * Move around where helper type is initialized to handle more scenarios * Remove commented code
Sergio0694
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Fix build breaks from AOT warning fixes * Improvements to GUID helper type lookup to avoid needing instantiated generic type * Move around where helper type is initialized to handle more scenarios * Remove commented code
Sergio0694
added a commit
that referenced
this pull request
Mar 13, 2024
* Guard MGT(Type) calls on NativeAOT * Set IsAotCompatible, treat AOT warnings as errors * Add throw paths on AOT for MarshalNonBlittable<T> * Make ManagedIPropertyValueImpl.UnboxValue AOT-safe * Fix all AOT warnings in WinRT.Runtime * Centralize [RDC] messages in TrimmingAttributeMessages * Fail build for AOT warnings in authoring test project * Replace Marshal.SizeOf<T>() with sizeof(T) on .NET 6+ * Address issues discovered after fixing AOT warnings (#1511) * Fix build breaks from AOT warning fixes * Improvements to GUID helper type lookup to avoid needing instantiated generic type * Move around where helper type is initialized to handle more scenarios * Remove commented code * Fix IL2073 warning in 'FindHelperType' * Centralize attribute constants in 'AttributeMessages' * Fix nullable and IPropertySet scenarios (#1519) * Experiment with changes to avoid nullable.value going down the helper type route * Fix build * Fix nullable structs and delegates * Fix * Fix tests * Fix issue where the class implementing the interface can be trimmed and we rely on IDIC cast to create an instance of the interface. But that doesn't work with the interface inherits generic interfaces on AOT. This addresses that by making sure there is a fallback class available to use for the interface. * Fix warning * Improvements to nullable scenario (caching and removing old code paths) * Move where we do generic type initialization for derived generic interfaces impl class * Fix issue with Interface<> missing in impl classes by converting most of the remaining ones using it to the new format * Add test * PR feedback * PR feedback for IID --------- Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues that came up after AOT checks were added to all our
MakeGenericTypecalls. The main issue that came up is the helper type for generic types can no longer be constructed. This was addressed in two ways.MarshalInterfacecalls, the helper type is registered before it gets there via theMethodsstatic classes in their static constructor which gets triggered as part of the generic type instantiations.MakeGenericTypecalls. The generic itself is still used as part of the IID generation but is done separately as it was before too as part of combining the signature that gets hashed.