Allow authoring scenarios to make use of abstract classes in their implementation #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an implementation detail that is not projected given abstract classes aren't projected in WinRT
…in a target so that the WinRT component source generator can also pick it up
Sergio0694
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract classes are not a concept in WinRT but authors of WinRT components may want to implement their components where they make of use abstract classes as their base class and might be public. Given we don't need to worry about projecting them, this PR allows for this scenario by ignoring the base type if it is abstract.
Also fixing an issue where
CsWinRTWindowsMetadatawas never set in authoring scenarios because it was set as part of a target and thereby the source generator was getting an empty value.