Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICustomQueryInterface.GetInterface implementation to never delegate a QI for IInspectable to the inner. #155

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Fix ICustomQueryInterface.GetInterface implementation to never delegate a QI for IInspectable to the inner. #155

merged 1 commit into from
Apr 17, 2020

Conversation

jkoritzinsky
Copy link
Member

Fixes #154

stevenbrix
stevenbrix approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@stevenbrix stevenbrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@jkoritzinsky jkoritzinsky merged commit 23332fa into master Apr 17, 2020
@jkoritzinsky jkoritzinsky deleted the jkoritzinsky/customqi-inspectable branch April 17, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbrix stevenbrix stevenbrix approved these changes

@Scottj1s Scottj1s Scottj1s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IComponentConnector.Connect not being called
3 participants
@jkoritzinsky @stevenbrix @Scottj1s