Skip closure allocation in ObjectReferenceWithContext<T> #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
performance
manodasanW
approved these changes
Apr 24, 2024
Sergio0694
force-pushed
the
user/sergiopedri/fix-obj-ref-trim-warning
branch
from
bba100c to
fb6e682
Compare
Sergio0694
force-pushed
the
user/sergiopedri/remove-obj-ref-context-alloc
branch
from
1ed967a to
a22dd40
Compare
Sergio0694
force-pushed
the
user/sergiopedri/fix-obj-ref-trim-warning
branch
from
fb6e682 to
088ff41
Compare
Sergio0694
force-pushed
the
user/sergiopedri/remove-obj-ref-context-alloc
branch
from
a22dd40 to
3d45626
Compare
…#1589) * Skip closures for 'Context.CallInContext' calls * Use function pointers instead of delegates * Move context lambda to FOH
Sergio0694
merged commit b3ae801
into
user/sergiopedri/fix-obj-ref-trim-warning
1 of 9 checks passed
Sergio0694
added a commit
that referenced
this pull request
Apr 26, 2024
* Skip closure allocation in ObjectReferenceWithContext<T> * Remove even more closure allocations in ObjectReferenceWithContext<T> (#1589) * Skip closures for 'Context.CallInContext' calls * Use function pointers instead of delegates * Move context lambda to FOH
Sergio0694
added a commit
that referenced
this pull request
Apr 26, 2024
* Fix trim warning for '_iid' in 'ObjectReference<T>' * Remove duplicate IID definition * Validate that input 'iid' arguments are not empty * Optimize 'CreateForCurrentContext' on NAOT * Fix generated 'ActivateInstance<I>' method * Fix trim warning in 'IMarshal' in Windows SDK * Skip closure allocation in ObjectReferenceWithContext<T> (#1587) * Skip closure allocation in ObjectReferenceWithContext<T> * Remove even more closure allocations in ObjectReferenceWithContext<T> (#1589) * Skip closures for 'Context.CallInContext' calls * Use function pointers instead of delegates * Move context lambda to FOH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization to
ObjectReferenceWithContext<T>on modern .NET, we can skip a closure.