Set 'TreatWarningsAsErrors' almost everywhere #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/warnings-as-errors
branch
3 times, most recently
from
ea7fb5e to
796b71b
Compare
Sergio0694
force-pushed
the
user/sergiopedri/warnings-as-errors
branch
2 times, most recently
from
90d5b28 to
c71838e
Compare
manodasanW
reviewed
Apr 29, 2024
src/cswinrt/strings/additions/Windows.Storage.Streams/WindowsRuntimeStreamExtensions.cs
Show resolved
Hide resolved
manodasanW
approved these changes
Apr 29, 2024
Sergio0694
force-pushed
the
user/sergiopedri/warnings-as-errors
branch
from
c71838e to
a4563c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables 'TreatWarningsAsErrors' in all published projects, plus in the functional and authoring tests. I've also removed all AOT warnings being marked explicitly as errors, since the new property replaces this (and also treats all other warnings the same).