Strip generated authoring metadata types #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/strip-authoring-metadata-type
branch
2 times, most recently
from
b4ce171
to
92bc8aa
Compare
manodasanW
reviewed
May 2, 2024
manodasanW
reviewed
May 2, 2024
manodasanW
approved these changes
May 2, 2024
Sergio0694
force-pushed
the
user/sergiopedri/strip-authoring-metadata-type
branch
from
ee427b9
to
79d082c
Compare
Sergio0694
force-pushed
the
user/sergiopedri/strip-authoring-metadata-type
branch
from
79d082c
to
6dd4ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strips all generated code from the
ABI.Impltypes in authoring scenarios. The types are only used for metadata lookups, and they're never actually instantiated, so they don't actually need to contain any logic to execute at runtime.