Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to IIDOptimizer and AOTOptimizer #1626

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

manodasanW
Copy link
Member

  • One of our recent changes to convert the IID properties in the methods class to the new format where it is a ref caused the AOT optimizer to detect it as a boxing scenario (going from byte[] to readonlyspan) when it isn't. Adding logic to detect that.
  • Removing misleading WinRT.Runtime message from IIDOptimizer which caused confusions to folks when they see it
  • Fixing IIDOptimizer to only write DLL if it patched something as I have seen in updated projections that it doesn't patch anything anymore in most cases as expected given we use the IID instead, but it is still writing its internal implementation type when not needed.

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@manodasanW manodasanW merged commit 6257088 into staging/AOT Jun 1, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/fixgeneratorvaluetype branch June 1, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants