Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing various AOT bugs #1648

Merged
merged 9 commits into from
Jun 30, 2024
Merged

Fixing various AOT bugs #1648

merged 9 commits into from
Jun 30, 2024

Conversation

manodasanW
Copy link
Member

  • Fixed issue where nested types were not correctly represented in the lookup table with a +.
  • Fixed issue where multi-level generic types were not correctly represented in the lookup table where the generics need to come at the end after all the nested generic types
  • Fix issue where ObservableCollection's use of SingleItemReadOnlyList causes interface not found issues due to the latter type is an internal type within the .NET runtime and thereby the source generator not being able to run on it. Special casing to handle that if ObservableCollection is found to be used.
  • Fix typo with IMapChangedEventArgs
  • Fix issue where for KeyValuePair, we didn't do a proper WinRT type check before generating the vtable causing issues with withing ABI functions not being there due to they are not expected to be there.

Fixes #1638
Fixes #1631
Fixes microsoft/microsoft-ui-xaml#9699
Fixes microsoft/microsoft-ui-xaml#9710

@manodasanW manodasanW merged commit fcb8316 into staging/AOT Jun 30, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/fixaotbugs branch June 30, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants