Fix merged component support in non-WinRT component projects #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One issue is that we still need the merged winmd written to the output location. That's done in the authoring targets via |
|
Is that not a separate feature? I mean one can also just copy all the individual .winmd-s to the output and just indicate the merged .dll as the implementation .dll for all of those .winmd-s, right? Eg. UWP currently does that, there's no single merged .winmd. |
|
I'm ok with getting this fix and just documenting that it does only thing and you might have to do some other targets work yourself. |
manodasanW
approved these changes
Jul 29, 2024
Sergio0694
force-pushed
the
user/sergiopedri/improve-merged-components
branch
from
21202e3
to
6f43f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generating WinRT exports to chain referenced components, from non-component projects.