Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property initializers and derived ObservableCollection #1686

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

manodasanW
Copy link
Member

The source generator was not detecting property initializers during lookup table generation. It was also not detecting scenarios where classes extended ObservableCollection. Both of those are now addressed.

Fixes #1685
Fixes #1663

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

src/Authoring/WinRT.SourceGenerator/AotOptimizer.cs Outdated Show resolved Hide resolved
src/Authoring/WinRT.SourceGenerator/AotOptimizer.cs Outdated Show resolved Hide resolved
@manodasanW manodasanW merged commit d5a6dc9 into staging/AOT Jul 30, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/propertyintiializer branch July 30, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants