Add 'Windows.UI.Xaml.*' exception types #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Aug 5, 2024
Sergio0694
force-pushed
the
user/sergiopedri/wux-exceptions
branch
from
7f4014a
to
8625f7f
Compare
manodasanW
reviewed
Aug 6, 2024
manodasanW
reviewed
Aug 6, 2024
Sergio0694
force-pushed
the
user/sergiopedri/wux-exceptions
branch
from
8625f7f
to
73fcb04
Compare
manodasanW
approved these changes
Aug 6, 2024
Sergio0694
force-pushed
the
user/sergiopedri/wux-exceptions
branch
from
a46ea53
to
27f2eb8
Compare
|
CI got far enough to show that tests are now passing. And previously everything else built fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the 4
Windows.UI.Xaml.*exception types we were missing, and uses a feature switch to throw either those or theMicrosoft.UI.Xaml.*types. Either group will be fully trimmed depending on the feature switch, so no size impact expected.