Don't emit default ctor for non activatable types #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
bug
|
Checked the .winmd manually, looks just fine:
|
manodasanW
reviewed
Oct 10, 2024
Sergio0694
force-pushed
the
user/sergiopedri/fix-non-activatable-types
branch
2 times, most recently
from
962bf12
to
e64282f
Compare
manodasanW
approved these changes
Oct 10, 2024
manodasanW
approved these changes
Oct 10, 2024
Sergio0694
force-pushed
the
user/sergiopedri/fix-non-activatable-types
branch
from
e64282f
to
fbdcb9f
Compare
Sergio0694
force-pushed
the
user/sergiopedri/fix-non-activatable-types
branch
from
fbdcb9f
to
67832b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the .winmd generation logic to avoid the default constructor for types that do have some non public constructor that takes any parameters. This bug is blocking the migration of one of our WinRT component projects in the Microsoft Store.