Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address ComWrappers breaking change and add prerelease policy #321

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Address ComWrappers breaking change and add prerelease policy #321

merged 5 commits into from
Jun 17, 2020

Conversation

Scottj1s
Copy link
Member

fixes #316

@Scottj1s
Copy link
Member Author

@jkoritzinsky - note the workaround for the winmd reference enforcement, which applies to ReferencePath when it should be ReferencePathWithRefAssemblies:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(111):
References="@(ReferencePathWithRefAssemblies)"

@jkoritzinsky
Copy link
Member

Can you file an issue on dotnet/sdk and tag me?

@Scottj1s Scottj1s merged commit e6126c1 into master Jun 17, 2020
@Scottj1s Scottj1s deleted the scottj1s/preview6 branch June 17, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to new ComSupport api surface
2 participants
@Scottj1s @jkoritzinsky