Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing IStringable array by ref scenarios #357

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

manodasanW
Copy link
Member

  • MarshalInterface was missing CopyAbiArray causing for scenarios where an array of interfaces such as IStringable is passed by ref to not compile. This PR adds that function.
  • Added the test cases from the testwinrt repo that validates these scenarios
  • One of the test cases ended up discovering another issue where the FromAbi API can be called with a ThisPtr which isn't for the default interface and end up calling the wrong API. Handled this by doing a QueryInterface via As to make the test pass, but I believe this is a generic problem that can affect any class and needs a generic fix.

Fixes #352

@manodasanW manodasanW requested a review from Scottj1s July 29, 2020 07:46
@manodasanW manodasanW merged commit 7e2f90a into master Aug 4, 2020
@manodasanW manodasanW deleted the manodasanw/stringablefix branch August 4, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'MarshalInterface<IStringable>' does not contain a definition for 'CopyAbiArray'
2 participants