Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angzhang/flattensample #453

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Angzhang/flattensample #453

merged 5 commits into from
Oct 6, 2020

Conversation

angelazhangmsft
Copy link
Contributor

flattening the sample directory structure:

Net5ProjectionSample
├───ConsoleAppSample
├───SimpleMathComponent
└───SimpleMathProjection
└───nuget

@Scottj1s
Copy link
Member

Scottj1s commented Oct 5, 2020

thanks - much better

don't forget this in the readme:
msbuild /p:platform=x64;configuration=debug CppWinRTProjectionSample\CppWinRTComponentProjectionSample.sln
msbuild /p:platform=x64;configuration=debug ConsoleAppSample\ConsoleAppSample.sln

Scottj1s
Scottj1s approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@Scottj1s Scottj1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@Scottj1s Scottj1s merged commit 73299a3 into master Oct 6, 2020
@Scottj1s Scottj1s deleted the angzhang/flattensample branch October 6, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scottj1s Scottj1s Scottj1s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelazhangmsft @Scottj1s