Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison to IntPtr.Zero. #499

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

jkoritzinsky
Copy link
Member

The current implementation is allowed by a Roslyn bug that's preserved for backcompat, but it doesn't work.

Discovered by WPF while they were taking in a new .NET SDK version.

…by a Roslyn bug that's preserved for backcompat.
@jkoritzinsky jkoritzinsky changed the title Fix comparison to intPtr.Zero. Fix comparison to IntPtr.Zero. Oct 14, 2020
@jkoritzinsky jkoritzinsky merged commit 5d10668 into master Oct 15, 2020
@jkoritzinsky jkoritzinsky deleted the jkoritzinsky/fix-intptr-compare branch October 15, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants