Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix max_ragged_sequence_count check in _schedule_prompts #470

Merged
merged 1 commit into from
May 13, 2024
Merged

fix max_ragged_sequence_count check in _schedule_prompts #470

merged 1 commit into from
May 13, 2024

Conversation

dc3671
Copy link
Contributor

@dc3671 dc3671 commented May 6, 2024

  • scheduling prompt should break when length of request equals max_ragged_sequence_count
  • considering there are flush requests, should use scheduled_requests.requests_to_run rather than scheduled_requests

@loadams @mrwyattii can you help review this fix? thanks~

@dc3671
Copy link
Contributor Author

dc3671 commented May 11, 2024

@loadams Can you trigger the CI again? Thanks

tohtana
tohtana approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@tohtana tohtana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dc3671 for your contributions!

@loadams loadams merged commit 56af8d0 into microsoft:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tohtana tohtana tohtana approved these changes

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

@awan-10 awan-10 Awaiting requested review from awan-10 awan-10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dc3671 @tohtana @loadams