Use valid semvers internally #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes please, this would be great. If you fix the build error I’ll do a quick check and get this in. Thanks! |
jablko
commented
Apr 21, 2022
| const firstTypedVersion = min( | ||
| mapDefined(versions, ({ hasTypes, version }) => (hasTypes ? version : undefined)), | ||
| (a, b) => b.greaterThan(a) | ||
| semver.compare |
Contributor
Author
There was a problem hiding this comment.
Use semver.compare().
Comment on lines
-17
to
-18
| (info.versions.has(notNeeded.versionString) && | ||
| !assertDefined(info.versions.get(notNeeded.versionString)).deprecated) |
Contributor
Author
There was a problem hiding this comment.
!isAlreadyDeprecated() ensures notNeeded is either < latest or not deprecated.
| } | ||
| const needsPublish = canPublish && pkg.contentHash !== latestVersionInfo.typesPublisherContentHash; | ||
| const patch = needsPublish | ||
| ? latestVersion!.minor === pkg.minor |
Contributor
Author
There was a problem hiding this comment.
latestPatchMatchingMajorAndMinor() ensures latestVersion.minor === pkg.minor.
| }); | ||
| return best(versionsWithTypings, (a, b) => a > b); | ||
| ): string | null { | ||
| return semver.maxSatisfying([...versions.keys()], `~${major}.${minor}`); |
Contributor
Author
There was a problem hiding this comment.
I replaced latestPatchMatchingMajorAndMinor() with the equivalent semver.maxSatisfying(..., `~${major}.${minor}`)
jablko
force-pushed
the
patch-37
branch
2 times, most recently
from
1b99e76 to
53072ff
Compare
Contributor
Author
|
Member
|
@sandersn any objections? |
andrewbranch
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we remove
semver.ts, and instead use the standardsemvernpm package, which is similar?semver.tsdoesn't handle some valid cases, e.g. andrewbranch/definitely-not-slow@d9d0828#diff-02cbc9970890cd33cf15c9ffb2f983aa63db1d290949662f06c134dad8fc9270R192 whereas switching to the standard package allows versions to be parsed consistently.