Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dev Box icon to account for scaling and size increases #235

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

bbonaby
Copy link
Contributor

@bbonaby bbonaby commented Jul 9, 2024

Summary of the pull request

Now that the PR to add the WSL extension has been checked into Dev Home Here: microsoft/devhome#3365. As mentioned in the description we need to update the icon for the Dev Box provider so that the icon does not appear pixeled in the create environment flow.

In the create environment flow the first page is where users select the provider they want to create an environment in. In this page environment providers are listed in the Settings cards UX and on the left is an icon and on the right is the name of the provider. In the above PR I updated the size of the icons in these cards from 20 to 40px. This led me seeing that the DevBox icon is pixeled and doesn't scale.

In this PR I'm adding a higher quality asset for the Dev Box provider icon that is 256 x 256 so that it can handle being scaled.
(Reason for 256 x 256 is to allow the icon to only be scaled down and never up). See info bar in icon scaling section: https://learn.microsoft.com/en-us/windows/apps/design/style/iconography/app-icon-construction#icon-scaling

Before this change:
Before icon size change

After this change:
After icon size change

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

confirmed icon is now not pixelated and is still showing up in the environments page.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@bbonaby bbonaby merged commit faf0a64 into main Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants