Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin widget flow #91

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Update pin widget flow #91

merged 1 commit into from
Jan 11, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Jan 8, 2024

Summary of the pull request

Accommodate the updated pin widget flow from microsoft/devhome#2110. Widgets are selected in the Add widget dialog and configured inline on the Dashboard, similar to how the Windows Widget Board does it.

References and relevant issues

Detailed description of the pull request / Additional comments

  • This PR makes significant changes to the customization template, removing the arrow button and Submit button. Instead, input validation is done on Save.
  • Since we don't have to communicate to the host that we're in configuration mode anymore, it is removed from the Data json.
  • CanPin is renamed to CanSave, a more accurate name.
  • Pinned indicates the state that the widget has ever had valid configuration data, and canceling customization will return the widget to that data.
  • Save and Cancel buttons are no longer labeled "positive" and "destructive" to give them normal styling.
  • Since there is no longer a different between "add" configuration state and "edit" configuration state, we can always show the Save and Cancel buttons in the Configuration template, although we only enable Cancel if there was once a valid state we can return to.

PR in Draft until we get screenshot assets.

image

Validation steps performed

PR checklist

@krschau krschau force-pushed the user/krschau/pin-flow branch from afbaf6e to cc889ba Compare January 8, 2024 21:59
@krschau krschau marked this pull request as draft January 8, 2024 22:06
@EricJohnson327 EricJohnson327 marked this pull request as ready for review January 11, 2024 20:52
@EricJohnson327 EricJohnson327 merged commit 0947a66 into main Jan 11, 2024
3 checks passed
@EricJohnson327 EricJohnson327 deleted the user/krschau/pin-flow branch January 11, 2024 20:52
@krschau krschau linked an issue Jan 25, 2024 that may be closed by this pull request
bbonaby pushed a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update widget pin flow Can we do away with the submit button and just keep the arrow?
4 participants