Handle out of bound access in D3DX12ParsePipelineStream #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbourn
requested changes
Nov 8, 2024
| @@ -1362,126 +1362,197 @@ inline HRESULT D3DX12ParsePipelineStream(const D3D12_PIPELINE_STATE_STREAM_DESC& | |||
| pCallbacks->ErrorDuplicateSubobject(SubobjectType); | |||
| return E_INVALIDARG; // disallow subobject duplicates in a stream | |||
| } | |||
| switch (SubobjectType) | |||
There was a problem hiding this comment.
since all these sizes are static, this seems like a switch statement isn't particular efficient as an implementation.
Why note create a const static array indexed by SubobjectType that has the sizeof in it? That way the look-up in trivial and the information is encoded in the readonly dataseg instead of as a code jumptable? The only reason the size was in the original switch statement is it already needed the code-paths for the callbacks.
Some use of static_assert should make it easy to notice when new pipeline state values are added as well as the runtime error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, was working on some project that uses DirectX-Headers, launched it with Asan and catched out of bound reads. This pull request fixes it