Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing validation for some intrinsic arguments that require literal #6289

Open
tex3d opened this issue Feb 13, 2024 · 1 comment
Open

Missing validation for some intrinsic arguments that require literal #6289

tex3d opened this issue Feb 13, 2024 · 1 comment
Labels
enhancement Feature suggestion validation Related to validation or signing
Milestone

Comments

@tex3d
Copy link
Contributor

tex3d commented Feb 13, 2024

Description
In hctdb.py, some intrinsics have arguments marked is_const=True. These arguments require immediate literal values. Currently, DxilValidation doesn't enforce this in a general way. Some intrinsics may have specific checks, but others are missing. For instance, #6280 updates some intrinsics that were missing this property, and they are still lacking validation for this property.

In DxilValidation, we should implement general check for DXIL intrinsic arguments with is_const=True property to ensure they are always immediate values. We can add a generated function to DxilValidationImpl.inc to look up the property, and we could add code to check that the necessary arguments are constant to the generated DxilInst_ helpers in DxilInstructions.h.

Environment

  • DXC version: any
  • Host Operating System: any
@tex3d tex3d added enhancement Feature suggestion needs-triage Awaiting triage labels Feb 13, 2024
@pow2clk pow2clk added the validation Related to validation or signing label Feb 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in HLSL Roadmap Feb 13, 2024
@pow2clk
Copy link
Member

pow2clk commented Feb 13, 2024

Missing validation that is not a regression. It could be masking compiler flaws. If it is, it might be worth getting in with 6.8 as it's an opportunity to make validation updates.

@pow2clk pow2clk removed the needs-triage Awaiting triage label Feb 14, 2024
@pow2clk pow2clk moved this to Done in HLSL Triage Feb 14, 2024
@damyanp damyanp added this to the Backlog milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature suggestion validation Related to validation or signing
Projects
Status: New
Status: Triaged
Development

No branches or pull requests

3 participants