You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
In hctdb.py, some intrinsics have arguments marked is_const=True. These arguments require immediate literal values. Currently, DxilValidation doesn't enforce this in a general way. Some intrinsics may have specific checks, but others are missing. For instance, #6280 updates some intrinsics that were missing this property, and they are still lacking validation for this property.
In DxilValidation, we should implement general check for DXIL intrinsic arguments with is_const=True property to ensure they are always immediate values. We can add a generated function to DxilValidationImpl.inc to look up the property, and we could add code to check that the necessary arguments are constant to the generated DxilInst_ helpers in DxilInstructions.h.
Environment
DXC version: any
Host Operating System: any
The text was updated successfully, but these errors were encountered:
Missing validation that is not a regression. It could be masking compiler flaws. If it is, it might be worth getting in with 6.8 as it's an opportunity to make validation updates.
Description
In
hctdb.py
, some intrinsics have arguments markedis_const=True
. These arguments require immediate literal values. Currently,DxilValidation
doesn't enforce this in a general way. Some intrinsics may have specific checks, but others are missing. For instance, #6280 updates some intrinsics that were missing this property, and they are still lacking validation for this property.In
DxilValidation
, we should implement general check for DXIL intrinsic arguments withis_const=True
property to ensure they are always immediate values. We can add a generated function toDxilValidationImpl.inc
to look up the property, and we could add code to check that the necessary arguments are constant to the generatedDxilInst_
helpers inDxilInstructions.h
.Environment
The text was updated successfully, but these errors were encountered: