NFC: Fix DXIL op is_const for Barrier and node create handle ops #6280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
This was referenced Feb 10, 2024
Set is_const=True for MetadataIdx on CreateNodeOutputHandle and CreateNodeInputRecordHandle
tex3d
force-pushed
the
fix-dxil-op-const-args
branch
from
63f5911 to
5562efe
Compare
python3kgae
approved these changes
Feb 15, 2024
tex3d
added a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Feb 16, 2024
…rosoft#6280) DXIL operations should use is_const=True for constant arguments. This allows for convenience methods to retrieve the constant value, and could (should, but currently doesn't) result in validation that the argument is constant. `BarrierByNodeRecordHandle` SemanticFlags argument must be constant. `MetadataIdx` for both `createNodeOutputHandle` and `CreateNodeInputRecordHandle` must be constant. (cherry picked from commit df588be)
tex3d
added a commit
that referenced
this pull request
Feb 17, 2024
…) (#6316) DXIL operations should use is_const=True for constant arguments. This allows for convenience methods to retrieve the constant value, and could (should, but currently doesn't) result in validation that the argument is constant. `BarrierByNodeRecordHandle` SemanticFlags argument must be constant. `MetadataIdx` for both `createNodeOutputHandle` and `CreateNodeInputRecordHandle` must be constant. (cherry picked from commit df588be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DXIL operations should use is_const=True for constant arguments. This allows for convenience methods to retrieve the constant value, and could (should, but currently doesn't) result in validation that the argument is constant.
BarrierByNodeRecordHandleSemanticFlags argument must be constant.MetadataIdxfor bothcreateNodeOutputHandleandCreateNodeInputRecordHandlemust be constant.