Add alignment to NodeRecordType including DXIL metadata update #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
tex3d
force-pushed
the
rdat-record-alignment
branch
4 times, most recently
from
800e5cf to
eef8c29
Compare
tex3d
force-pushed
the
rdat-record-alignment
branch
from
eef8c29 to
e0f9207
Compare
tex3d
force-pushed
the
rdat-record-alignment
branch
from
e0f9207 to
c175bff
Compare
Since DxilValidation for RDAT part expects exact binary comparison match, we need to restore any missing alignment from the RDAT before we generate RDAT and compare. Alignment for records used with GetNodeRecordPtr() will be restored from llvm, and not overwritten by this alignment from RDAT, so it still varifies that alignment matches type llvm module when available.
This reverts commit 7ac5291.
This reverts commit 4eb1d2b.
tex3d
force-pushed
the
rdat-record-alignment
branch
from
c175bff to
43509fb
Compare
Originally, the test macro copied the record from input to output, but that was changed, so the name was stale.
tex3d
added a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Feb 29, 2024
…soft#6279) This change adds NodeRecordType alignment field to RDAT to make it possible to validate pointer and stride alignment in the runtime. This includes a change to DXIL metadata to preserve the record alignment without requiring recovery by looking for GetNodeRecordPtr. Fixes microsoft#6270 (cherry picked from commit 66ba5a1)
tex3d
added a commit
that referenced
this pull request
Feb 29, 2024
#6374) This change adds NodeRecordType alignment field to RDAT to make it possible to validate pointer and stride alignment in the runtime. This includes a change to DXIL metadata to preserve the record alignment without requiring recovery by looking for GetNodeRecordPtr. Fixes #6270 (cherry picked from commit 66ba5a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds NodeRecordType alignment field to RDAT to make it possible to validate pointer and stride alignment in the runtime.
This includes a change to DXIL metadata to preserve the record alignment without requiring recovery by looking for GetNodeRecordPtr.
Fixes #6270