Add checks to advanced tex ops exectests #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two of the Advanced Texture Ops feature tests were missing the check for the feature in addition to the check for 6.7 support. This adds those checks
|
✅ Build DirectXShaderCompiler 1.0.1839 completed (commit 5b4c2894b6 by @pow2clk) |
bfavela
reviewed
Jul 13, 2022
| @@ -4181,6 +4185,12 @@ TEST_F(ExecutionTest, ATOSampleCmpLevelTest) { | |||
| if (!CreateDevice(&pDevice, D3D_SHADER_MODEL_6_7)) | |||
| return; | |||
|
|
|||
| if (!DoesDeviceSupportAdvancedTexOps(pDevice)) { | |||
| WEX::Logging::Log::Comment(L"Device does not support Advanced Texture Operations."); | |||
There was a problem hiding this comment.
Not sure if these get parsed by any automated scripts, but there's minor difference between this text and the previous check ('Ops' vs 'Operations.')
There was a problem hiding this comment.
It's also a slightly different case since this is not a skip, but just an FYI note that rarely gets read. I'd have changed it for consistency anyway, but I set it to automerge. oh well!
bfavela
approved these changes
Jul 13, 2022
pow2clk
added a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Jul 13, 2022
Two of the Advanced Texture Ops feature tests were missing the check for the feature in addition to the check for 6.7 support. This adds those checks
pow2clk
added a commit
that referenced
this pull request
Jul 13, 2022
Two of the Advanced Texture Ops feature tests were missing the check for the feature in addition to the check for 6.7 support. This adds those checks Merge of #4551 to release-1.7.2207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the Advanced Texture Ops feature tests were missing the check for
the feature in addition to the check for 6.7 support. This adds those
checks